Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink unsafe blocks #220

Closed
wants to merge 1 commit into from
Closed

Shrink unsafe blocks #220

wants to merge 1 commit into from

Conversation

peamaeq
Copy link

@peamaeq peamaeq commented Jun 23, 2022

In these function you use the unsafe keyword for some safe expressions.

We need to mark unsafe operations more precisely using unsafe keyword. Keeping unsafe blocks small can bring many benefits. For example, when mistakes happen, we can locate any errors related to memory safety within an unsafe block. This is the balance between Safe and Unsafe Rust. The separation is designed to make using Safe Rust as ergonomic as possible, but requires extra effort and care when writing Unsafe Rust.

Hope this PR can help you.
Best regards.
References
https://doc.rust-lang.org/nomicon/safe-unsafe-meaning.html
https://doc.rust-lang.org/book/ch19-01-unsafe-rust.html

@tbu-
Copy link
Collaborator

tbu- commented Jun 23, 2022

I don't see that this brings much benefit. The parts you moved outside of the unsafe blocks are part of the code that upholds the safety.

@bluss
Copy link
Owner

bluss commented Nov 12, 2022

Thanks and my thoughts echo what @tbu- said. While the PR's changes are correct and harmless, this is not a logic for updating unsafe code blocks that I believe in.

@bluss bluss closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants