Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#48 - custom fixers added #47

Merged
merged 2 commits into from Feb 20, 2022
Merged

#48 - custom fixers added #47

merged 2 commits into from Feb 20, 2022

Conversation

krzysztofrewak
Copy link
Member

@krzysztofrewak krzysztofrewak commented Jan 21, 2022

I added following:

PhpCsFixerCustomFixers\Fixer\ConstructorEmptyBracesFixer;
PhpCsFixerCustomFixers\Fixer\InternalClassCasingFixer;
PhpCsFixerCustomFixers\Fixer\MultilinePromotedPropertiesFixer;
PhpCsFixerCustomFixers\Fixer\NoUselessCommentFixer;
PhpCsFixerCustomFixers\Fixer\PhpdocArrayStyleFixer;
PhpCsFixerCustomFixers\Fixer\PromotedConstructorPropertyFixer;
PhpCsFixerCustomFixers\Fixer\SingleSpaceAfterStatementFixer;
PhpCsFixerCustomFixers\Fixer\SingleSpaceBeforeStatementFixer;
PhpCsFixerCustomFixers\Fixer\StringableInterfaceFixer;

I found out that nullable readonly properties are not working as we would expect; I created issue here (PHP-CS-Fixer/PHP-CS-Fixer#6221) and it was fixed here (PHP-CS-Fixer/PHP-CS-Fixer#6224), but for some reasons it's still not working with ECS underneath our Codestyle.

It should close #48.

@krzysztofrewak krzysztofrewak changed the title - readonlies fix #48 - custom fixers added Feb 10, 2022
@krzysztofrewak krzysztofrewak marked this pull request as ready for review February 10, 2022 08:33
@krzysztofrewak krzysztofrewak merged commit e9d1c81 into main Feb 20, 2022
@krzysztofrewak krzysztofrewak deleted the readonlies-fix branch February 20, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kubawerlos/php-cs-fixer-custom-fixers
3 participants