Fix crash with NameError through decorator during collection #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
fix-nameerror_with_decorator
branch
from
c8317a7
to
94770e8
Compare
blueyed
added a commit
that referenced
this pull request
Sep 25, 2020
NOTE: fixing/reverting of `doc = getattr(mod, "docstring", None)` was missed in 3153740 (pytest-dev#4723). It was added initially in pytest-dev#2870, but never made it into a final Python release. Basically reverts / revisits based on changes introduced in 734c435. Adjusts a7dfc6f (#243).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref pytest-dev#4984.
TODO:
ref: pytest-dev#9355