FIX: make sure declared but empty streams report 0 length #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
force-pushed
the
fix/empty_stream_num_count
branch
from
67339a4
to
38d83cf
Compare
tacaswell
force-pushed
the
fix/empty_stream_num_count
branch
from
38d83cf
to
a98009e
Compare
|
Can this be closed when #1579 is merged? It has the same effects on the tests: |
|
Yes, I think that this will be made redunedent by #1579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the stream is declared (via pre-declare) but never populated report that it has 0 events in the stop documents (rather than just memory-holing it and not including an entry).
Motivation and Context
If there is a descriptor doc it should show up in the list of streams in the stop document.
How Has This Been Tested?
Added test (and manually tested).