feat: add descriptionFacets to profiles #2456
Open
+909
−856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's something wrong with the lex-cli, is it reliant on bash returning a sorted directory file listing? because the diffs are mostly just that. I don't know what seems to be causing it, a different |
mary-ext
force-pushed
the
feat/profile-description-facets
branch
from
feb1013
to
b007a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any other blocker aside from the ability to serialize facets back into something that can be edited in the text input, which had been implemented a while back via bluesky-social/social-app#2485.
Adding this field removes the need for the app to parse and resolve handles just to display someone's profile bio.