feat: Better error handling for Airnotes with no recent data #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://airnote-live-pr-40.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca77ks2rrk044quseso0. |
|
Your Render PR Server URL is https://start-airnote-live-pr-40.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca77ksirrk044qusess0. |
tjvantoll
commented
May 25, 2022
| 'http://localhost:5000', | ||
| 'https://airnote.live' | ||
| ] | ||
| origin: ["http://localhost:5555", "https://airnote.live"], |
There was a problem hiding this comment.
This port is all that changed. The rest is Prettier auto formatting.
paigen11
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
. This PR adds messaging for Airnote users that previously had data, and do not currently.
Story: https://www.pivotaltracker.com/story/show/181203517
There’s also a small workaround in here, because apparently
localhost:5000sometimes doesn’t work on macOS. That was a fun 30 minutes.