Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager: Rework list sorting #2035

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

infirit
Copy link
Contributor

@infirit infirit commented Feb 26, 2023

Our list got very confusing with newly found device rows being inserted in the list based on name or datetime added. When you have lot's of devices it becomes a pain to find them so we need a better way.

We primarily now sort whether a device is paired. The logic behind this is that these are the devices the user most likely is interested in. Next we sort all connected devices below and the remaining ones at the bottom.

image

@cschramm
Copy link
Member

cschramm commented Feb 27, 2023

One could argue if the most important group should be at the top or at the bottom, but I guess top is best as you might need to scroll to it otherwise.

Also adding these groups is not really a reason to remove the options and always sort by name in ascending order within the groups. Should not hurt, though, I don't think the sort options are a commonly used feature and anybody will miss them (might be completely wrong 😆).

One thing that bugs me, though, but I'm not sure what to do with that, is that an item moves now when getting (un)paired or (dis)connected. 🤔

@infirit
Copy link
Contributor Author

infirit commented Feb 27, 2023

One could argue if the most important group should be at the top or at the bottom, but I guess top is best as you might need to scroll to it otherwise.

I can make ascending/descending an option again.

Also adding these groups is not really a reason to remove the options and always sort by name in ascending order within the groups. Should not hurt, though, I don't think the sort options are a commonly used feature and anybody will miss them (might be completely wrong 😆).

Sure, I can expand and readd the options. A magic default sort, always alphabetical and always by added.

One thing that bugs me, though, but I'm not sure what to do with that, is that an item moves now when getting (un)paired or (dis)connected. 🤔

I can make it a timed sort, let's say an initial sort and then every couple minutes? It would still move at some point but not immediately anymore. Or have a list of devices (iters) that should be delayed for X amount of time. Would that help?

Our list got very confusing with newly found device rows being inserted
in the list based on name or datetime added. When you have lot's of
devices it becomes a pain to find them so we need a better way.

We primarily now sort whether a device is paired. The logic behind this
is that these are the devices the user most likely is interested in. Next
we sort all connected devices below and the remaining ones at the bottom.
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@infirit
Copy link
Contributor Author

infirit commented Mar 3, 2023

Added back in the existing sort options. Will poke at the delayed sort idea I have next.

@github-actions github-actions bot added the stale label Feb 22, 2024
@github-actions github-actions bot closed this Mar 1, 2024
@cschramm cschramm removed the stale label Mar 1, 2024
@cschramm cschramm reopened this Mar 1, 2024
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants