Meson uninstalled attempt 2 #1793
Conversation
infirit
force-pushed
the
uninstalledv2
branch
19 times, most recently
from
fa1dbdc
to
9b4ecda
Compare
|
Fixed the jobs. Just one concern/question, the release job version check command works when I run it in a terminal. Not sure it'll work in CI 🤔 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Fixed per comments. |
|
To be honest, I'm not super happy with the workflow yet, as a debug cycle now means editing the sources, syncing them into the build directory with One idea: Shouldn't it be rather easy to reliably detect that an app is running from a build directory instead of using |
| @@ -63,9 +66,12 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - run: apt-get update | |||
| - run: apt-get install -y -qq --no-install-recommends automake autoconf libtool autopoint gettext libglib2.0-dev python-gi-dev libbluetooth-dev iproute2 libgirepository1.0-dev gir1.2-gtk-3.0 gir1.2-nm-1.0 libpulse0 libpulse-mainloop-glib0 | |||
| - run: apt-get install -y -qq --no-install-recommends meson gettext gettext libglib2.0-dev python-gi-dev libbluetooth-dev iproute2 libgirepository1.0-dev gir1.2-gtk-3.0 gir1.2-nm-1.0 libpulse0 libpulse-mainloop-glib0 | |||
| @@ -1,4 +1,7 @@ | |||
| cython = find_program('cython', required: true) | |||
| cython = find_program('cython', required: false) | |||
There was a problem hiding this comment.
find_program takes additional arguments as fallbacks, so find_program('cython', 'cython3', required: false) should be fine.
There was a problem hiding this comment.
Cool, didn't know that. I'll fix that.
| ICON_PATH = os.path.join(_dirname, 'data', 'icons') | ||
| PIXMAP_PATH = os.path.join(_dirname, 'data', 'icons', 'pixmaps') | ||
| UI_PATH = os.path.join(_dirname, 'data', 'ui') | ||
| _builddir = os.path.abspath(os.path.dirname(__file__)) |
There was a problem hiding this comment.
At least launch is looking at the wrong BIN_DIR for me, so that it does not find the apps.
There was a problem hiding this comment.
No .. is intentional but I'll check why your bindir is incorrect. What is your build dir named?
There was a problem hiding this comment.
Name was build and BIN_DIR was pointing to build/blueman which seems very plausible to me as that's where Constants.py is and what I thus expect from os.path.dirname(__file__).
There was a problem hiding this comment.
Yeah, I was wrong, will fix. I confused this with the apps.
|
We could drop Constants for another way to configure paths. I could move these things to a JSON file and allow the apps to load a custom one on the command line. |
|
Totally forgot to add that README.md and Dependencies.md need updates. |
I commented here about some possible solutions: #1207 (comment) Loading a json file from the command line doesn't seem like the best solution to me as |
|
This appears to work for me. Yes it copies all the files to the build dir but for now I don't care. I just want it to work so we can drop autotools. If someone want to spend the time to figure out other options they can and send a PR.
It needs some testing and I will have to update the release job in main.
edit. I'll also fix the other jobs over the weekend.