New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new HTTPS and SVCB record types #1402
Conversation
8e64be5
to
3f8eb48
Compare
3f8eb48
to
6f86a55
Compare
Codecov Report
@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 85.10% 83.67% -1.43%
==========================================
Files 153 167 +14
Lines 15042 15872 +830
==========================================
+ Hits 12801 13280 +479
- Misses 2241 2592 +351 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far.
Ok, I fixed all the |
1b7ba9c
to
178347c
Compare
Ok, @djc, I think this is ready to merge... we have full end-to-end support now for server, client, and resolver now. |
8ee2c4b
to
47e8b20
Compare
There's just too much code here for me to closely review. I presume most of it is based on copy/pasting from other places? It's probably fine, we'll iron out any bugs as it starts getting used I suppose. |
Sorry, for the amount of code... I tried to do it in stages to build up the entire thing... but yeah, in the end I don't see a way to make this smaller than handling all of these cases. |
If it helps, I think it's all perfect ;) |
47e8b20
to
d14af60
Compare
just rebased. |
@briansmith @djc @sayrer @moonshiner
Ok, had some time today, through these record types in.
Some notes, currently this does not validate theSvcbParamValue
against theSvcbParamKey
type.Currently this is not supported in the Zone file for the server, but that shouldn't be too hard, so I think I'll leave this in draft until I can do that.
This can be tested with:
see: https://github.com/MikeBishop/dns-alt-svc
fixes: #1323