feat: get current source #1350
Merged
feat: get current source #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@luanpotter I added the tests for this feature and fixed the integration tests. Do you want to review again? |
spydon
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a way to get the current source. Theoretically the developer could save the source in its own variable, what they most probably currently do. But this is tended to be error prone. This change would provide an easy access to the current source which also considers the
release / release modefunctionality.This change would also be necessary to provide better logs from the library side.
Checklist
fix:,feat:,docs:,chore:etc).///, where necessary.Breaking Change
Related Issues