Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make converter compatible with older PyYAML #272

Merged
merged 1 commit into from Jul 2, 2020

Conversation

btravouillon
Copy link
Member

CentOS 8 ship with PyYAML 3.12 while I used some features introduced
with 5.1, which are incompatible. See yaml/pyyaml#265.

It appears I tested it in my virtualenv setup with latest PyYAML 5.3.1.... 馃憥

CentOS 8 ship with PyYAML 3.12 while I used some features introduced
with 5.1, which are incompatible. See yaml/pyyaml#265.
@btravouillon btravouillon added the bug Something isn't working label Jul 1, 2020
@btravouillon
Copy link
Member Author

btravouillon commented Jul 1, 2020

Without this patch, the code fails on CentOS 8 while converting the inventory files:

[root@management1 bluebanquise]# ./tools/inventory-converter-1.3-network_interfaces.py inventory/cluster/nodes/computes.yml 
Traceback (most recent call last):
  File "./tools/inventory-converter-1.3-network_interfaces.py", line 77, in <module>
    main()
  File "./tools/inventory-converter-1.3-network_interfaces.py", line 63, in main
    inventory = yaml.load(fd, Loader=yaml.FullLoader)
AttributeError: module 'yaml' has no attribute 'FullLoader'

Copy link
Member

@oxedions oxedions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I had same kind of issues on Centos.

Merging.

@oxedions oxedions merged commit dd3d905 into bluebanquise:master Jul 2, 2020
@btravouillon btravouillon deleted the fix/inventory_helper branch July 2, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants