Feature/tls #17
Merged
Feature/tls #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittie
commented
Oct 17, 2022
mwittie
commented
Oct 17, 2022
mwittie
commented
Oct 17, 2022
mwittie
commented
Oct 17, 2022
tahardi
approved these changes
Oct 18, 2022
dlm
approved these changes
Oct 19, 2022
These checks make the code and the testing more complicated. Instead, we check that the internal fields are not nil after creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the tools needed by the
nitridingserver(future PR) to get certificates to create TLS connections.Notable changes:
type Builder[T any] interface, which allows us to remove all the specific builder interfaces likeAttesterBuilderetc. For not I only used this interface to get rid specific builder interfaces in this PR, but I plan on updating older code as well. Not doing it now because it would result in changes all over the place and make the review of the new TLS code harder.