Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unfamiliar messages by Explorer.Staking.ContractState module #3620

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Feb 10, 2021

Motivation

This small PR fixes a bug which led to permanent Staking DApp server side restarting due to unhandled :ssl_closed message. The bug relates to benoitc/hackney#464

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Feb 10, 2021

Pull Request Test Coverage Report for Build b09b65b50c632dc026b7046f1f345160245eb850-PR-3620

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.1%) to 64.76%

Files with Coverage Reduction New Missed Lines %
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build e94e3948c9e855dd231bd378a3efb00455d8eba2: -2.1%
Covered Lines: 2095
Relevant Lines: 3235

💛 - Coveralls

@varasev varasev changed the title Add temporary logging to Staking DApp Ignore unfamiliar messages by Explorer.Staking.ContractState module Feb 11, 2021
@varasev varasev force-pushed the va-staking-dapp-check-snapshotting branch from 6b9f1af to b09b65b Compare February 11, 2021 10:37
@vbaranov vbaranov merged commit c6d43e2 into master Feb 11, 2021
@vbaranov vbaranov deleted the va-staking-dapp-check-snapshotting branch February 11, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants