Add --report-unused-disable-directives to lint:eslint

[kachkaev]

🌟 What is the purpose of this PR?

This PR makes sure that yarn lint:eslint does not exits with 0 if there are unused ESLint disable comments left in the codebase. These comments should be automatically removed on save because we have reportUnusedDisableDirectives: true in our base ESLint config. However, when we do bulk-edits, unused directives may remain as warnings and not fail the CI.

🔗 Related links

• Asana task (internal)
• Add --report-unused-disable-directives to lint:eslint hashintel/hash#1608
• Docs

🐾 Next steps

If there is support for reportUnusedDisableDirectives: "error" upstream, we can remove the CLI option.

🛡 What tests cover this?

I tested the option manually by adding // eslint-disable-next-line in a random place. yarn fix:eslint worked equally with and without the CLI option so I only added it for lint:eslint.

[codecov]

Codecov Report

Merging #812 (d9443c5) into main (e5a1e7d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   62.56%   62.56%           
=======================================
  Files         271      271           
  Lines        4266     4266           
  Branches     1004     1004           
=======================================
  Hits         2669     2669           
  Misses       1257     1257           
  Partials      340      340           

Flag	Coverage Δ
site-integration-chrome	61.50% <ø> (+0.02%)	⬆️
site-integration-firefox	61.53% <ø> (-0.17%)	⬇️
site-integration-iphone	57.07% <ø> (+0.02%)	⬆️
site-integration-pixel	59.44% <ø> (+0.02%)	⬆️
site-integration-safari	56.68% <ø> (-0.92%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.