Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next to v13 #692

Merged
merged 17 commits into from Nov 14, 2022
Merged

Update Next to v13 #692

merged 17 commits into from Nov 14, 2022

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Oct 19, 2022

Asana task (internal, see comments)

The PR was blocked by getsentry/sentry-javascript#6072. I can update #709 once this PR is merged.

@github-actions github-actions bot added area: apps > site The blockprotocol.org website, inc. Hub (app) area: apps Relates to non-content work in `apps` (area) area: dependencies Relates to third-party or otherwise imported dependencies (area) area: infra Relates to version control, CI, CD or IaC (area) labels Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #692 (b96a915) into main (9eef039) will decrease coverage by 0.25%.
The diff coverage is n/a.

❗ Current head b96a915 differs from pull request most recent head 3efe49c. Consider uploading reports for the commit 3efe49c to get more accurate results

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   62.50%   62.24%   -0.26%     
==========================================
  Files         271      271              
  Lines        4256     4256              
  Branches     1005     1005              
==========================================
- Hits         2660     2649      -11     
- Misses       1257     1269      +12     
+ Partials      339      338       -1     
Flag Coverage Δ
site-integration-chrome 61.30% <ø> (-0.05%) ⬇️
site-integration-firefox 61.37% <ø> (-0.10%) ⬇️
site-integration-iphone 56.76% <ø> (-0.03%) ⬇️
site-integration-pixel 59.25% <ø> (-0.12%) ⬇️
site-integration-safari 57.26% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/site/src/components/base-link.tsx 90.00% <ø> (ø)
apps/site/src/components/footer-banner.tsx 84.00% <ø> (ø)
...rc/components/pages/home/composable-interfaces.tsx 100.00% <ø> (ø)
...site/src/components/pages/home/confined-blocks.tsx 100.00% <ø> (ø)
apps/site/src/components/pages/home/header.tsx 100.00% <ø> (ø)
...src/components/pages/home/interoperable-blocks.tsx 100.00% <ø> (ø)
apps/site/src/lib/api-client.ts 86.11% <0.00%> (-8.34%) ⬇️
.../site/src/pages/[shortname]/types/[title].page.tsx 59.45% <0.00%> (-8.11%) ⬇️
apps/site/src/components/mdx/mdx-page-content.tsx 71.83% <0.00%> (-4.23%) ⬇️
...nents/entity-types/schema-editor/schema-editor.tsx 46.77% <0.00%> (-1.62%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kachkaev kachkaev changed the title Update Next Update Next to v13 Oct 31, 2022
@@ -54,6 +54,7 @@ export const BaseLink: FunctionComponent<BaseLinkProps> = ({
// Setting to true triggers Next.js warning: https://nextjs.org/docs/messages/prefetch-true-deprecated
prefetch={external ? false : undefined}
passHref
legacyBehavior
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -6,7 +6,7 @@ import {
PaperProps,
Typography,
} from "@mui/material";
import Image from "next/image";
import Image from "next/legacy/image";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added area: packages area: libs > mock-block-dock Affects the `mock-block-dock` package (library) labels Oct 31, 2022
@@ -50,7 +50,7 @@
"react-resizable": "^3.0.4",
"slate": "^0.82.1",
"slate-react": "^0.83.1",
"styled-jsx": "5.0.7",
"styled-jsx": "^5.0.7",
Copy link
Contributor Author

@kachkaev kachkaev Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syncs with nextstyled-jsx@5.1.0 (pinned) to avoid duplicates in yarn.lock

Copy link
Member

@CiaranMn CiaranMn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take advantage of the new NextJS features at some point, as they seem to offer improved performance for little effort – I've created a task (internal) to come back to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: apps > site The blockprotocol.org website, inc. Hub (app) area: apps Relates to non-content work in `apps` (area) area: dependencies Relates to third-party or otherwise imported dependencies (area) area: infra Relates to version control, CI, CD or IaC (area) area: libs > mock-block-dock Affects the `mock-block-dock` package (library)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants