New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Next to v13 #692
Update Next to v13 #692
Conversation
Codecov Report
@@ Coverage Diff @@
## main #692 +/- ##
==========================================
- Coverage 62.50% 62.24% -0.26%
==========================================
Files 271 271
Lines 4256 4256
Branches 1005 1005
==========================================
- Hits 2660 2649 -11
- Misses 1257 1269 +12
+ Partials 339 338 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -54,6 +54,7 @@ export const BaseLink: FunctionComponent<BaseLinkProps> = ({ | |||
// Setting to true triggers Next.js warning: https://nextjs.org/docs/messages/prefetch-true-deprecated | |||
prefetch={external ? false : undefined} | |||
passHref | |||
legacyBehavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,7 +6,7 @@ import { | |||
PaperProps, | |||
Typography, | |||
} from "@mui/material"; | |||
import Image from "next/image"; | |||
import Image from "next/legacy/image"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -50,7 +50,7 @@ | |||
"react-resizable": "^3.0.4", | |||
"slate": "^0.82.1", | |||
"slate-react": "^0.83.1", | |||
"styled-jsx": "5.0.7", | |||
"styled-jsx": "^5.0.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syncs with next
→ styled-jsx@5.1.0
(pinned) to avoid duplicates in yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should take advantage of the new NextJS features at some point, as they seem to offer improved performance for little effort – I've created a task (internal) to come back to them.
Asana task (internal, see comments)
The PR was blocked by getsentry/sentry-javascript#6072. I can update #709 once this PR is merged.