Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run changeset linter in Version Packages PRs #586

Merged
merged 2 commits into from Sep 7, 2022

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Sep 7, 2022

Continues #579, fixes CI failures in Version Packages PRs.

From docs:

NOTE: status will fail if you are in the middle of running version or publish. If you want to get changeset status at the time of a version increase and publish, you need to run it immediately before running version.

See failed run example for #578


Extra: I’ve also bumped @changesets/cli to get this upstream PR in: changesets/changesets#905

Older versions of @changesets/cli use built-in Prettier (v1). It generates lists with alternating * and -, which in turn breaks yarn lint:markdownint. Upstream issues: changesets/changesets#938, prettier/prettier#4369.

@github-actions github-actions bot added the area: infra Relates to version control, CI, CD or IaC (area) label Sep 7, 2022
run: |
git pull --force --no-tags origin main:main ## https://github.com/changesets/changesets/issues/517
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this command one step up to reduce time gap between repo checkout and branch reference creation

@kachkaev kachkaev changed the title Do not run changeset in CI for Version Packages Do not run changeset linter in Version Packages PR Sep 7, 2022
@kachkaev kachkaev changed the title Do not run changeset linter in Version Packages PR Do not run changeset linter in Version Packages PRs Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #586 (0b92842) into main (d3b19a5) will not change coverage.
The diff coverage is n/a.

❗ Current head 0b92842 differs from pull request most recent head 3603ec1. Consider uploading reports for the commit 3603ec1 to get more accurate results

@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files         263      263           
  Lines        4149     4149           
  Branches      995      995           
=======================================
  Hits         2409     2409           
  Misses       1434     1434           
  Partials      306      306           
Flag Coverage Δ
site-integration 58.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the area: dependencies Relates to third-party or otherwise imported dependencies (area) label Sep 7, 2022
@kachkaev kachkaev marked this pull request as ready for review September 7, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies Relates to third-party or otherwise imported dependencies (area) area: infra Relates to version control, CI, CD or IaC (area)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants