Introduce changesets for npm version management
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dependencies
kachkaev
commented
Jul 5, 2022
| "block-template": patch | ||
| --- | ||
|
|
||
| Add `"private": true` to all three template `package.json` files |
There was a problem hiding this comment.
- How do I stop changesets trying to publish certain packages changesets/changesets#783
- https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#ignore-array-of-packages
Alternatively, we can remove "packages/block-template/templates/*" from package.json → workspaces. Conceptually, templates are not packages as far as the monorepo is concerned. They are just file assets.
kachkaev
commented
Jul 6, 2022
| @@ -20,7 +20,7 @@ jobs: | |||
| if: ${{ github.event.inputs.confirmation }} | |||
| runs-on: ubuntu-20.04 | |||
| steps: | |||
| - run: echo "https://registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc | |||
| - run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc | |||
There was a problem hiding this comment.
I hope this can fix
npm ERR! code ENEEDAUTH
npm ERR! need auth This command requires you to be logged in to https://registry.npmjs.org/
npm ERR! need auth You need to authorize this machine using `npm adduser`
https://github.com/blockprotocol/blockprotocol/actions/runs/2621063593
CiaranMn
approved these changes
Jul 7, 2022
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| if: github.repository == 'blockprotocol/blockprotocol' |
There was a problem hiding this comment.
What's this about? Isn't it always?
There was a problem hiding this comment.
I saw this if in one repo that uses changesets (not sure I remember which one). This is a protection against running the pipeline in a fork.
This was referenced Jul 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/changesets/changesets
Instructions
Standard releases
Create N PRs with
.changeset/*.mdfiles in them (each file corresponds to a single CHANGELOG entry)Find latest PR named ‘version packages’ (e.g. Version Packages statelyai/xstate#3366)
Review and merge that PR
Wait for CI to pass
Enjoy new versions!
Snapshot releases
Run these commands locally:
This flow should improve once changesets/changesets#855 is released. In the meantime, I can add a new manual GitHub action for snapshot releases (perhaps, in a follow-up PR).
UPD: Two fixes in the initial setup
@changesets/changelog-githubdependency #423