Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] (newapp) Upgrade to react 18 alpha #2478

Closed
wants to merge 3 commits into from
Closed

Conversation

flybayer
Copy link
Member

What are the changes and their implications?

Upgrade to react 18 alpha

kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 11, 2021
@flybayer flybayer added the status/blocked Waiting on something else label Jun 11, 2021
@blitzjs-bot blitzjs-bot moved this from In Review to Blocked in Dashboard Jun 11, 2021
@flybayer
Copy link
Member Author

flybayer commented Jun 11, 2021

Status

It appears react 18 works beautifully. However react-testing-library doesn't work well with it yet, causing a bunch of console errors (even though code runs correctly).

So this PR is pending a new react-testing-library release after testing-library/react-testing-library#925 lands

@flybayer
Copy link
Member Author

flybayer commented Jul 5, 2021

Superseded by #2547

@flybayer flybayer closed this Jul 5, 2021
@blitzjs-bot blitzjs-bot added status/done and removed status/blocked Waiting on something else labels Jul 5, 2021
@blitzjs-bot blitzjs-bot moved this from Blocked to Done in Dashboard Jul 5, 2021
@dillondotzip dillondotzip changed the title (newapp) Upgrade to react 18 alpha [legacy-framework] (newapp) Upgrade to react 18 alpha Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants