Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Established PostgreSQL database connection #1

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Conversation

blake-enyart
Copy link
Owner

@blake-enyart blake-enyart commented Jul 10, 2019

Worked on with @Vjp888

  • Check this if the PR has been approved by the team to be a quick patch and the rest of this form will not be filled out

What functionality does this accomplish?

closes #

Description:

Troubleshooting start here with psycopg2 installation

Continued to code along with Agatha Codes article

What did you struggle on to complete?

  • All of it

Current Test Suite:

Test Coverage Percentage: x%

  • No Tests have been changed
  • Some Tests have been changed
  • All of the Tests have been changed(Please describe what in the world happened):

Checklist:

  • My code has no unused/commented out code
  • I have reviewed my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have fully tested my code
  • I have partially tested my code (please explain why):

Helpful Resources:

Review Requests(optional):

@Vjp888: Could you just double check this PR since most of the work isn't necessarily captured by the code sent with this PR?

Please include an emoji of how you feel about this branch:

馃槴

Copy link
Collaborator

@Vjp888 Vjp888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Everything looks good.

This was certainly a trial be we heavily documented the issues we ran into to help prevent these large hiccups in the future.

I approve the merge, everything was functional and up and running when pushed.

@Vjp888 Vjp888 merged commit fd24383 into master Jul 10, 2019
@Vjp888 Vjp888 deleted the bte-pg-db-setup branch July 10, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants