Test for strings within strings as of phpunit 7.5

The old way is deprecated from phpunit 8.0 sebastianbergmann/phpunit#3422
bjuppa · Feb 28, 2019 · 1ea4a5f · 1ea4a5f
1 parent a17b0d3
commit 1ea4a5f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/composer.json b/composer.json
@@ -26,7 +26,7 @@
   "require-dev": {
     "orchestra/testbench": "~3.6",
     "laravel/framework": ">=5.6.25",
-    "phpunit/phpunit": ">6.5",
+    "phpunit/phpunit": ">=7.5",
     "erusev/parsedown": "^1.7",
     "graham-campbell/markdown": "^10.0",
     "mockery/mockery": "^1.0",

diff --git a/tests/Feature/GrahamCampbellMarkdownBlogEntryTest.php b/tests/Feature/GrahamCampbellMarkdownBlogEntryTest.php
@@ -28,8 +28,8 @@ public function test_body_markdown_is_parsed()
 
         $html_string = $entry->getContent()->toHtml();
 
-        $this->assertContains('<h1>The Headline</h1>', $html_string);
-        $this->assertContains('<p>A <em>paragraph</em></p>', $html_string);
+        $this->assertStringContainsString('<h1>The Headline</h1>', $html_string);
+        $this->assertStringContainsString('<p>A <em>paragraph</em></p>', $html_string);
     }
 
     public function test_image_markdown_is_parsed()
@@ -39,7 +39,7 @@ public function test_image_markdown_is_parsed()
 
         $html_string = $entry->getImage()->toHtml();
 
-        $this->assertContains('alt="Alt text"', $html_string);
-        $this->assertContains('title="Optional title"', $html_string);
+        $this->assertStringContainsString('alt="Alt text"', $html_string);
+        $this->assertStringContainsString('title="Optional title"', $html_string);
     }
 }
diff --git a/tests/Feature/ParsedownBlogEntryTest.php b/tests/Feature/ParsedownBlogEntryTest.php
@@ -18,8 +18,8 @@ public function test_body_markdown_is_parsed()
 
         $html_string = $entry->getContent()->toHtml();
 
-        $this->assertContains('<h1>The Headline</h1>', $html_string);
-        $this->assertContains('<p>A <em>paragraph</em></p>', $html_string);
+        $this->assertStringContainsString('<h1>The Headline</h1>', $html_string);
+        $this->assertStringContainsString('<p>A <em>paragraph</em></p>', $html_string);
     }
 
     public function test_image_markdown_is_parsed()
@@ -29,7 +29,7 @@ public function test_image_markdown_is_parsed()
 
         $html_string = $entry->getImage()->toHtml();
 
-        $this->assertContains('alt="Alt text"', $html_string);
-        $this->assertContains('title="Optional title"', $html_string);
+        $this->assertStringContainsString('alt="Alt text"', $html_string);
+        $this->assertStringContainsString('title="Optional title"', $html_string);
     }
 }