Avoid sql connection timeout #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data Table creation is slow. connection may be timing out while we create it.
cscharf
approved these changes
Jun 25, 2021
MGibson1
added a commit
that referenced
this pull request
Jun 25, 2021
* Creat TVP prior to opening sql connection Data Table creation is slow. connection may be timing out while we create it. * USe MARS-enabled connections to fix connection issue dotnet/SqlClient#54 (cherry picked from commit 9841502)
|
cherry picked to |
dlundgren
pushed a commit
to dlundgren/server
that referenced
this pull request
Dec 14, 2021
* Creat TVP prior to opening sql connection Data Table creation is slow. connection may be timing out while we create it. * USe MARS-enabled connections to fix connection issue dotnet/SqlClient#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We finally pegged down the Sql connection closed issue to being related to this issue: dotnet/SqlClient#54.
The Issue provides a workaround: user MARS. We can mitigate by altering the connection string for the methods which have trouble.