Remove default request size limit for direct uploads (#1406)

* Remove default request size limit - direct upload * Disable size limit for self-hosted attachments
bitwarden · Jun 25, 2021 · ee1223b · ee1223b
1 parent 61e4119
commit ee1223b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/Api/Controllers/CiphersController.cs b/src/Api/Controllers/CiphersController.cs
@@ -622,6 +622,7 @@ public async Task<AttachmentUploadDataResponseModel> RenewFileUploadUrl(string i
         }
 
         [HttpPost("{id}/attachment/{attachmentId}")]
+        [DisableRequestSizeLimit]
         [DisableFormValueModelBinding]
         public async Task PostFileForExistingAttachment(string id, string attachmentId)
         {
@@ -630,6 +631,11 @@ public async Task PostFileForExistingAttachment(string id, string attachmentId)
                 throw new BadRequestException("Invalid content.");
             }
 
+            if (!_globalSettings.SelfHosted)
+            {
+                throw new BadRequestException("Invalid endpoint for non self-hosted servers.");
+            }
+
             var userId = _userService.GetProperUserId(User).Value;
             var cipher = await _cipherRepository.GetByIdAsync(new Guid(id), userId);
             var attachments = cipher?.GetAttachments();

diff --git a/src/Api/Controllers/SendsController.cs b/src/Api/Controllers/SendsController.cs
@@ -249,6 +249,7 @@ public async Task<SendFileUploadDataResponseModel> RenewFileUpload(string id, st
         }
 
         [HttpPost("{id}/file/{fileId}")]
+        [DisableRequestSizeLimit]
         [DisableFormValueModelBinding]
         public async Task PostFileForExistingSend(string id, string fileId)
         {