[SM-660] move sm-no-items to CL

[willmartian]

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

• moves the sm-no-items component to the CL
• renames to bit-no-items
• adds Storybook stories

Code changes

• bitwarden_license/bit-web/src/app/secrets-manager/*: Renamed all instances of sm-no-items; updated module imports

Screenshots

No visual changes.

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[Hinton]

Looks good, a few small notes. And should we add some quick notes what the component is used for in the component file, which should show up in storybook?

/**
 * Component for displaying a message when there are no items to display. Expects title, description and button slots.
 */

[Hinton]

We should write a short section about slots on https://contributing.bitwarden.com/architecture/clients/presentation/angular.

[Hinton]

Seems we didn't have to import this for any of the other secret modules, is this needed?

[willmartian]

The other components where it is used are declared in the shared SM module. I went ahead and just added NoItemsModule to the shared module's exports, so this is no longer needed.

[willmartian]

Looks good, a few small notes. And should we add some quick notes what the component is used for in the component file, which should show up in storybook?

/**
 * Component for displaying a message when there are no items to display. Expects title, description and button slots.
 */

Tried adding this in a few different places and couldn't get it to show up in Storybook. It looks like that feature might come out next release?

[Hinton]

LGTM, thanks!