Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Deploying with Docker" docs for Elixir 1.12 #737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nclark
Copy link

@nclark nclark commented Jun 18, 2021

Summary of changes

I'm not necessarily suggesting this PR be merged, I'm curious to hear what others think about the solution. My app's docker image was heavily influenced by the "Deploying with Docker" distillery docs, and I ran into an issue when upgrading to Elixir 1.12. Namely using the elixir:1.12.1-alpine base image results in errors being thrown because libstdc++.so.6 is missing. Following along at erlef/docker-elixir#20 I see this is because the new JIT feature in OTP 24 expects to dynamically link libc, but alpine uses musl instead. The solution there is to add libstdc++ back into the final container.

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and
related material intended to be compiled or integrated with the source code for Distillery
(the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be
considered, it must contain your agreement to license under the MIT license.

includes libstdc++ in final image for OTP 24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant