Fix -sname support #704
Closed
Fix -sname support #704
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-sname support was not working in all cases (e.g. bitwalker#699). This fixes at least the things mentioned in the above issue.
|
Any news on this? I have the same problem being not able to ping or remote_console to my app with sname because of the inverted if statement in this PR |
albertored
suggested changes
Oct 25, 2019
| HOSTNAME="$(get_hostname)" | ||
| OLD_NAME="$NAME" | ||
| NAME="$NAME@$HOSTNAME" | ||
| NAME_TYPE="-name" |
There was a problem hiding this comment.
We also need to include this if here
if [[ ! "$HOSTNAME" =~ ^[^\.]+\..*$ ]]; then
# If the hostname is not fully qualified, change the name type
NAME_TYPE="-sname"
fito make it work with not fully qualified hostnames
There was a problem hiding this comment.
@albertored can you please add it and then we can merge it in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
-snamesupport was not working in all cases (e.g. #699).This fixes at least the things mentioned in the above issue.
Checklist
Licensing/Copyright
By submitting this PR, you agree to the following statement, please read before submission!
I certify that I own, and have sufficient rights to contribute, all source code and
related material intended to be compiled or integrated with the source code for Distillery
(the "Contribution"). My Contribution is licensed under the MIT License.
NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.