Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/postgresql-ha] Fix typo in postgresql-ha/templates/NOTES.txt preventing deployments #25994

Merged
merged 2 commits into from
May 20, 2024
Merged

[bitnami/postgresql-ha] Fix typo in postgresql-ha/templates/NOTES.txt preventing deployments #25994

merged 2 commits into from
May 20, 2024

Conversation

kraihn
Copy link
Contributor

@kraihn kraihn commented May 17, 2024

Description of the change

Fixes a type preventing the deployment of the postgresql-ha chart through FluxCD and increments the chart version

Benefits

Starting with postgresql-ha version 13.0.0, deployments don't work with FluxCD

Possible drawbacks

None that I can think of.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@kraihn
Fix typo
b4d55f9 
Signed-off-by: Jared Dickson <code@jareddickson.com>
@kraihn
Increment chart version
ba590c2 
Signed-off-by: Jared Dickson <code@jareddickson.com>
@github-actions github-actions bot added postgresql-ha triage Triage is needed labels May 17, 2024
@github-actions github-actions bot requested a review from javsalgar May 17, 2024 20:14
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 18, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 18, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 18, 2024 16:42
@github-actions github-actions bot requested a review from rafariossaa May 18, 2024 16:42
rafariossaa
rafariossaa approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for spotting this.

LGTM

@rafariossaa rafariossaa merged commit 26e0feb into bitnami:main May 20, 2024
25 of 26 checks passed
fmulero pushed a commit to fmulero/charts that referenced this pull request May 22, 2024
@kraihn @fmulero
[bitnami/postgresql-ha] Fix typo in postgresql-ha/templates/NOTES.txt…
2ee9bcf 
… preventing deployments (bitnami#25994)

* Fix typo

Signed-off-by: Jared Dickson <code@jareddickson.com>

* Increment chart version

Signed-off-by: Jared Dickson <code@jareddickson.com>

---------

Signed-off-by: Jared Dickson <code@jareddickson.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa rafariossaa approved these changes

Assignees

@rafariossaa rafariossaa

Labels
postgresql-ha solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in postgresql-ha/templates/NOTES.txt causes deployment failure
4 participants
@kraihn @rafariossaa @javsalgar @carrodher