Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/minio] PDB review #25986

Merged
merged 2 commits into from
May 20, 2024
Merged

[bitnami/minio] PDB review #25986

merged 2 commits into from
May 20, 2024

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented May 17, 2024

Description of the change

Enabled PodDisruptionBudget by default and little fixes in PDB configuration to keep it aligned with current templates.

Benefits

PDB protects our applications from voluntary disruption initiated by cluster administrators.
Keep our charts up to date according to our templates.

Possible drawbacks

None

Adition information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@fmulero
[bitnami/minio] PDB review
87216e1 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero fmulero enabled auto-merge (squash) May 17, 2024 15:58
@github-actions github-actions bot added the minio label May 17, 2024
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label May 17, 2024
@github-actions github-actions bot requested a review from andresbono May 17, 2024 15:59
@andresbono
Merge branch 'main' into feature/minio-pdb
0539fad 
Signed-off-by: Andrés Bono <andresbono@vmware.com>
@fmulero fmulero merged commit 06839ae into bitnami:main May 20, 2024
9 checks passed
fmulero added a commit to fmulero/charts that referenced this pull request May 22, 2024
@fmulero @andresbono
[bitnami/minio] PDB review (bitnami#25986)
76a038d 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Signed-off-by: Andrés Bono <andresbono@vmware.com>
Co-authored-by: Andrés Bono <andresbono@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero fmulero deleted the feature/minio-pdb branch June 4, 2024 12:47
@fmulero fmulero added the pdb label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresbono andresbono andresbono approved these changes

Assignees

@andresbono andresbono

@fmulero fmulero

Labels
bitnami minio pdb solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmulero @andresbono @bitnami-bot