Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in postgresql-ha/templates/NOTES.txt causes deployment failure #25993

Closed
kraihn opened this issue May 17, 2024 · 3 comments · Fixed by #25994
Closed

Typo in postgresql-ha/templates/NOTES.txt causes deployment failure #25993

kraihn opened this issue May 17, 2024 · 3 comments · Fixed by #25994
Assignees
@javsalgar
Labels
postgresql-ha solved tech-issues The user has a technical issue about an application triage Triage is needed

Comments

@kraihn
Copy link
Contributor

kraihn commented May 17, 2024 •
edited by carrodher

Name and Version

bitnami/postgresql-ha 13.0.0

What architecture are you using?

None

What steps will reproduce the bug?

  1. A Kubernetes cluster running FluxCD v2.1.2
  2. Deploying a FluxCD CRD for HelmRelease
  3. Bitnami postgresql-ha chart values
  4. There is an error parsing the Helm Chart:
reconciliation failed: Helm upgrade failed: template: postgresql-ha/templates/NOTES.txt:60:63: executing "postgresql-ha/templates/NOTES.txt" at <include "postgresql-ha.pgppol" .>: error calling include: template: no template "postgresql-ha.pgppol" associated with template "gotpl"

Are you using any custom parameters or values?

persistence:
    storageClass: secret
postgresql:
    password: secret
    repmgrPassword: secret
pgpool:
    adminPassword: secret
    customUsersSecret: secret
metrics:
    enabled

What is the expected behavior?

The Helm Chart should deploy successfully.

What do you see instead?

reconciliation failed: Helm upgrade failed: template: postgresql-ha/templates/NOTES.txt:60:63: executing "postgresql-ha/templates/NOTES.txt" at <include "postgresql-ha.pgppol" .>: error calling include: template: no template "postgresql-ha.pgppol" associated with template "gotpl"

Additional information

It appears a type was introduced in the chart version 13.0.0 upgrade that introduced network policies.

https://github.com/bitnami/charts/blob/main/bitnami/postgresql-ha/templates/NOTES.txt

The type is on line 60
postgresql-ha.pgppol should be postgresql-ha.pgpool
@kraihn kraihn added the tech-issues The user has a technical issue about an application label May 17, 2024
@github-actions github-actions bot added the triage Triage is needed label May 17, 2024
@kraihn kraihn mentioned this issue May 17, 2024
Merged
4 tasks
@kraihn
Copy link
Contributor Author

kraihn commented May 17, 2024

I've created a pull request that I believe will resolve the issue. However, it won't correct any of the 13.x versions since it's only a patch upgrade in 14.x.

I don't need 13.x patched, but should we patch it? And how would I go about doing that?

@kraihn
Copy link
Contributor Author

kraihn commented May 17, 2024

@javsalgar, I'm not sure if my change will fix the issue, or if another include will be attempted and failed. I have limited experience writing Helm charts, and haven't determined how to test this locally yet.

@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javsalgar javsalgar

Labels
postgresql-ha solved tech-issues The user has a technical issue about an application triage Triage is needed
Projects
None yet
Milestone
No milestone
3 participants
@kraihn @javsalgar @carrodher