Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost install workaround #372

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Conversation

dweinber
Copy link
Member

@dweinber dweinber commented Jan 9, 2024

Description

Since 6th January 2024, installing dependencies failed due to boost, which is used by react-native.
See issues boostorg/boost#843 and facebook/react-native#42180 for details, the second issue contains the official react-native workaround proposal.

Note: A fix should be available in react-native version 0.72.9 which should be an easy upgrade (only the RN package version changed according to the RN Upgrade Helper and wouldn't require the workaround. However, we're using also react-native-tvos which hasn't released a fix yet so we anyway need the workaround for now.

Changes

After installing the dependencies from npm, the new patch files will be applied to the installed react-native npm package. The patch files contain updated download locations for boost.

Checklist

  • 🗒 CHANGELOG entry

@dweinber dweinber marked this pull request as ready for review January 9, 2024 09:48
@rolandkakonyi rolandkakonyi self-requested a review January 9, 2024 10:17
Copy link
Contributor

@rolandkakonyi rolandkakonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green! Nice job! Thanks for the effort!

@dweinber dweinber merged commit c9c8767 into development Jan 9, 2024
9 checks passed
@dweinber dweinber deleted the feature/boost-install-workaround branch January 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants