Bump minimum declared versions of dependencies #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs cargo check on nightly requesting a build with minimum versions of dependencies declared as supported.
To minimal versions required to build most features (all other than core
and rustc-dep-of-std) with --all-targets.
Minimal required versions discovered by manual binsearch between
minimum compatible version declared currently and the newest one
available, and rerunning
cargo check --all \
--features serde,arbitrary,bytemuck,std,example_generated \
--all-targets -Z minimal-versions
to verify if it builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating
bitflagsdependency of another crate, I found out thatbitflags' declared dependency versions are lower than needed to actually build the crate.This PR adds a GH workflow check inspired by the one from
gbm.rsthat attempts a build with the minimal compatible versions of all dependencies.Another commit in the PR bumps the declared versions to earliest ones I identified as working, to make the workflow pass.
The workflow builds all features other than
coreandrustc-dep-of-std.cargo check --all --all-features --all-targetsfailed for me on main with mentions of rustc/std, which successfully scared me away 馃槅 I have zero experience hacking on rustc/std so I don't even know how those are used.Hopefully this, or some parts of it can be useful as is 馃槃