New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for impl mode structs to be repr(packed) #388
Conversation
Seems like CI failing is unrelated? |
This should probably have a test to ensure it continues to work. |
Seems like there aren't any tests for |
Hi @GnomedDev 👋 Thanks for the PR. If you add a test to |
2bcecf8
to
43fe59f
Compare
43fe59f
to
843cc04
Compare
Hey @KodrAus, just done that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GnomedDev! This looks good to me.
Thanks for merging, any chance for a release now with this in? I'm stoked to use it! |
This allows the following code to compile, with the only downside being a possible copy of the internal value for non-packed types, although I'm somewhat certain that would be optimised out.