Ignore clippy lint in generated code #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also adds the lifetime specifier for several |
26 tasks
KodrAus
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Thanks @Jake-Shadle 👍
We should probably add Clippy to our own CI too to make sure we catch these things rather than end-users having to.
|
It's a good thing to have for sure! Though I think you could still run into trouble with lints that are accept by default like this particular case, in addition to behavior changes (new lints/default changes/etc) between Rust stable versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a project enables clippy::indexing_slicing the code generated by the macro will emit the warning, which for many projects will also fail CI.