Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an "impl_arbitrary" feature to enable implementing Arbitrary. #260

Closed
wants to merge 12 commits into from
Closed

Add an "impl_arbitrary" feature to enable implementing Arbitrary. #260

wants to merge 12 commits into from

Commits on Aug 18, 2021

  1. Add an "impl_arbitrary" feature to enable implementing Arbitrary. 

    Fixes bitflags#248.
    @sunfishcode
    sunfishcode committed Aug 18, 2021
    Copy the full SHA
    56058b5 View commit details
    Browse the repository at this point in the history

  2. Update src/lib.rs 

    Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
    @sunfishcode @konsumlamm
    sunfishcode and konsumlamm committed Aug 18, 2021
    Copy the full SHA
    66be426 View commit details
    Browse the repository at this point in the history

  3. Test impl_arbitrary in CI. 

    This enables impl_arbitrary when example_generated is enabled.
    @sunfishcode
    sunfishcode committed Aug 18, 2021
    Copy the full SHA
    ad754db View commit details
    Browse the repository at this point in the history

  4. Document the "impl_arbitrary" feature in the README.md.

    @sunfishcode
    sunfishcode committed Aug 18, 2021
    Copy the full SHA
    dec18af View commit details
    Browse the repository at this point in the history

  5. Use absolute paths to arbirary symbols.

    @sunfishcode
    sunfishcode committed Aug 18, 2021
    Copy the full SHA
    d970ee0 View commit details
    Browse the repository at this point in the history

  6. Depend on and re-export "arbitrary". 

    Drop the "impl_arbitrary" feature, now that we can just use "arbitrary".
    @sunfishcode
    sunfishcode committed Aug 18, 2021
    Copy the full SHA
    fee72ad View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Update Cargo.toml 

    Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
    @sunfishcode @konsumlamm
    sunfishcode and konsumlamm committed Aug 19, 2021
    Copy the full SHA
    8efeb65 View commit details
    Browse the repository at this point in the history

  2. Update .github/workflows/rust.yml 

    Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
    @sunfishcode @konsumlamm
    sunfishcode and konsumlamm committed Aug 19, 2021
    Copy the full SHA
    fc99c5e View commit details
    Browse the repository at this point in the history

  3. Fix a typo.

    @sunfishcode
    sunfishcode committed Aug 19, 2021
    Copy the full SHA
    230933b View commit details
    Browse the repository at this point in the history

  4. Move the compile-pass test into a toplevel test. 

    And make the other changes suggested by @konsumlamm.
    @sunfishcode
    sunfishcode committed Aug 19, 2021
    Copy the full SHA
    411d152 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Avoid adding arbitrary to the example_generated feature. 

    Add it to the docs.rs enabled features instead, as suggested in the
PR comments.
    @sunfishcode
    sunfishcode committed Aug 25, 2021
    Copy the full SHA
    1a1e375 View commit details
    Browse the repository at this point in the history

  2. Re-enable the arbitrary feature in CI.

    @sunfishcode
    sunfishcode committed Aug 25, 2021
    Copy the full SHA
    fab01fa View commit details
    Browse the repository at this point in the history