Merge pull request #380 from KodrAus/ci/compile-pass-clippy

Allow some new pedantic clippy lints

.github/workflows/rust.yml

@@ -84,18 +84,19 @@ jobs:
           cd ./tests/smoke-test
           cargo +$msrv build
 
-  mips:
-    name: Tests / MIPS (Big Endian)
+  miri:
+    name: "Miri"
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout sources
-        uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
-
-      - name: Install Cross
-        run: cargo install cross
-
+      - uses: actions/checkout@v3
+      - name: Install Miri
+        run: |
+          rustup toolchain install nightly --component miri
+          cargo +nightly miri setup
       - name: Default features
-        run: cross test --target mips-unknown-linux-gnu
+        run: cargo +nightly miri test
+      - name: BE
+        run: cargo +nightly miri test --target s390x-unknown-linux-gnu
 
   clippy:
     name: Clippy

README.md

@@ -46,11 +46,17 @@ use bitflags::bitflags;
 
 // The `bitflags!` macro generates `struct`s that manage a set of flags.
 bitflags! {
+    /// Represents a set of flags.
     #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
     struct Flags: u32 {
+        /// The value `A`, at bit position `0`.
         const A = 0b00000001;
+        /// The value `B`, at bit position `1`.
         const B = 0b00000010;
+        /// The value `C`, at bit position `2`.
         const C = 0b00000100;
+
+        /// The combination of `A`, `B`, and `C`.
         const ABC = Self::A.bits() | Self::B.bits() | Self::C.bits();
     }
 }

src/lib.rs

@@ -481,7 +481,8 @@ macro_rules! bitflags {
             non_upper_case_globals,
             clippy::assign_op_pattern,
             clippy::indexing_slicing,
-            clippy::same_name_method
+            clippy::same_name_method,
+            clippy::iter_without_into_iter,
         )]
         const _: () = {
             // Declared in a "hidden" scope that can't be reached directly
@@ -553,7 +554,8 @@ macro_rules! bitflags {
             unused_mut,
             unused_imports,
             non_upper_case_globals,
-            clippy::assign_op_pattern
+            clippy::assign_op_pattern,
+            clippy::iter_without_into_iter,
         )]
         const _: () = {
             __impl_public_bitflags! {

src/tests/iter.rs

@@ -3,6 +3,7 @@ use super::*;
 use crate::Flags;
 
 #[test]
+#[cfg(not(miri))] // Very slow in miri
 fn roundtrip() {
     for a in 0u8..=255 {
         for b in 0u8..=255 {

src/tests/parser.rs

@@ -6,6 +6,7 @@ use crate::{
 };
 
 #[test]
+#[cfg(not(miri))] // Very slow in miri
 fn roundtrip() {
     let mut s = String::new();
 

tests/compile-pass/item_positions.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::let_unit_value)]
+
 #[macro_use]
 extern crate bitflags;
 

tests/compile-pass/missing_docs.rs

@@ -0,0 +1,19 @@
+/*!
+Crate-level doc
+*/
+
+#![deny(missing_docs)]
+
+use bitflags::bitflags;
+
+bitflags! {
+    #[allow(missing_docs)]
+    pub struct MyFlags: u32 {
+        #[allow(missing_docs)]
+        const A = 1;
+        #[allow(missing_docs)]
+        const B = 2;
+    }
+}
+
+fn main() {}

tests/compile.rs

@@ -2,13 +2,15 @@
 // an impossible build between error messages emitted on various channels.
 // Since https://github.com/dtolnay/trybuild/pull/170 we always need to have a
 // `stderr` file for each test so we can't simply ignore the output on different channels.
+#[cfg(not(miri))]
 #[rustversion::attr(beta, test)]
 #[allow(dead_code)]
 fn fail() {
     let t = trybuild::TestCases::new();
     t.compile_fail("tests/compile-fail/**/*.rs");
 }
 
+#[cfg(not(miri))]
 #[test]
 fn pass() {
     let t = trybuild::TestCases::new();