Move to Uint8Array and js-sha256 for browsers #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will move the whole chain of base-x, bs58, and bs58check to remove Buffer.
The biggest change security-wise is that It adds a dependency to js-sha256.
I have reviewed their source code for 0.9.0 and it looks good to me.
I also tested browserify, and it uses the hash_browser.js and includes the js-sha256 dependency properly.