Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Uint8Array and js-sha256 for browsers #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junderw
Copy link
Member

@junderw junderw commented Feb 17, 2022

This will move the whole chain of base-x, bs58, and bs58check to remove Buffer.

The biggest change security-wise is that It adds a dependency to js-sha256.

I have reviewed their source code for 0.9.0 and it looks good to me.

I also tested browserify, and it uses the hash_browser.js and includes the js-sha256 dependency properly.

@gruve-p
Copy link

gruve-p commented Feb 24, 2022

NACK on adding an unmaintained dependency of js-sha256.

unsafe eval issue:
emn178/js-sha256#26
near/near-api-js#757 (comment) (they are even replacing js-sha256: near/near-api-js#800 )

Last commit was in 2017. Author is not responding on issues, nor is he interested in giving somebody else permissions to maintain it: emn178/js-sha256#29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants