Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure the key network is updated in the KeyMap as well #800

Merged
merged 1 commit into from
Nov 24, 2022
Merged

fix: ensure the key network is updated in the KeyMap as well #800

merged 1 commit into from
Nov 24, 2022

Conversation

afilini
Copy link
Member

@afilini afilini commented Nov 23, 2022

Description

Otherwise we may have inconsistencies with keys in the descriptor that have a network and keys in the keymap that are different.

Notes to the reviewers

Adding it to the 0.25 milestone since it's just a quick fix

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@afilini afilini added this to the Release 0.25.0 Feature Freeze milestone Nov 23, 2022
@afilini
fix: ensure the key network is updated in the KeyMap as well
150f4d6 
Otherwise we may have inconsistencies with keys in the descriptor that
have a network and keys in the keymap that are different.
@vladimirfomene vladimirfomene mentioned this pull request Nov 24, 2022
Merged
8 tasks
@notmandatory notmandatory added the bug Something isn't working label Nov 24, 2022
notmandatory
notmandatory approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 150f4d6

@notmandatory notmandatory merged commit 8b68cf9 into bitcoindevkit:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@afilini afilini

Labels
bug Something isn't working
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.25.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afilini @notmandatory