Remove duplicated InsufficientFunds error member

[e1a0a0ea]

closes #1440

Description

• Replace CreateTxError::InsufficientFunds use by coin_selection::Error::InsufficientFunds
• Remove InsufficientFunds member from CreateTxError enum
• Rename coin_selection::Error to coin_selection::CoinSelectionError

Notes to the reviewers

• We could also keep both members but rename one of them to avoid confusion

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[ValuedMammal]

I tend to favor the name Error and qualifying it with its containing module, i.e. coin_selection::Error.

[notmandatory]

Please also setup commit signing, see: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

[matthiasdebernardini]

Maybe this belongs here better, basically, can this be disabled in anything but Network::Bitcoin?

#1440 (comment)

[oleonardolima]

Concept ACK, I do agree with Value's comment, and mind Steve's comment above.

[oleonardolima]

Maybe this belongs here better, basically, can this be disabled in anything but Network::Bitcoin?

#1440 (comment)

I personally don't think it's a good idea to "error-gate" based on the bitcoin::Network type, I would expect all behaviors that happen on mainnet (production per se) to happen on others, and even some nasty behaviors we may catch while testing on testnet/signet being prevented to land on mainnet code 😅.

[matthiasdebernardini]

That's a good point, @oleonardolima maybe the juice is not worth the squeeze on making this change.

[oleonardolima]

Looking good! I left some comments, and I also think that it could be squashed into a single commit.

[oleonardolima]

@e1a0a0ea You could probably use a qualified version: coin_selection::Error::InsufficientFunds instead 🤔

[ValuedMammal]

Or just import the InsufficientFunds variant itself.

[evanlinjin]

I'm not a fan of importing the enum variant (can become confusing imo). I prefer the more verbose, but clearer option.

[notmandatory]

Please rebase again and fixup commits into one commit then this should be ready to merge.

[evanlinjin]

ACK 29c8a00

[notmandatory]

ACK 29c8a00