Skip to content

Commit

Permalink
Merge #129: Bump bdk version to 0.24.0
Browse files Browse the repository at this point in the history
b667738 Bump bdk-reserves version to 0.24 (Steve Myers)
b21fb4b Fix wasm compiler descriptor translate_pk (Steve Myers)
b1b2a2a Bump bdk version to 0.24.0 (Steve Myers)

Pull request description:

  ### Description

  Update BDK to the latest version, 0.24.0.

  ### Notes to the reviewers

  I also had to add `base64` as a new dependency because it's not exported by `bdk`.

  There's probably a more elegant way to fix the `wasm.rs` compiler function for descriptor.translate_pk, and I don't
  know how create a unit test it since it only runs on wasm32. But at least it builds so I think that's close enough for now.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  rajarshimaitra:
    tACK b667738

Tree-SHA512: f68e6302c882a0080baa7c670bbf76e735ae3b315c47568f1b643dec1d929c161925bf4e1eaa321e8cb3e186e77a31a4576391aeebcc8823e0b04b42bcea7fc8
  • Loading branch information
notmandatory committed Nov 15, 2022
2 parents 6088302 + b667738 commit af925ab
Show file tree
Hide file tree
Showing 6 changed files with 303 additions and 208 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cont_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
- name: Update toolchain
run: rustup update
- name: Build
run: cargo build --target wasm32-unknown-unknown --no-default-features --features esplora-reqwest,async-interface,compiler
run: cargo build --target wasm32-unknown-unknown --no-default-features --features esplora-reqwest,async-interface,compiler,dev-getrandom-wasm

fmt:
name: Rust fmt
Expand Down

0 comments on commit af925ab

Please sign in to comment.