Genericide BIP9 in variable/type names and comments #21399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-BEGIN VERIFY SCRIPT- sed -i -e 's/\bBIP9\b/versionbits/g; s/BIP9/VBits/g; s/bip9\([.()]\)/deployment_details\1/g' $(git grep -il BIP9 src) -END VERIFY SCRIPT-
|
Actually, I wonder if it would be easier overall to just omit all these changes until things have settled? |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 10, 2021
Merged
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Further splitting up of #19573)
Most of bcec418, but mostly converted to a scripted-diff to aid in backporting.
Hopefully getting this in by itself will make reviewing other PRs simpler.