multiprocess: Add bitcoin-wallet -ipcconnect option #19460
Draft
+2,703
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrahtBot
added
Build system
Docs
GUI
P2P
RPC/REST/ZMQ
Tests
Utils/log/libs
Wallet
labels
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 7, 2020
Merged
Draft
Spawn node subprocess instead of running node code internally
Spawn wallet subprocess instead of running wallet code internally
Add .wallet/.gui suffixes to log files created by bitcoin-gui and bitcoin-wallet processes so they don't clash with bitcoin-node log file.
Add `-ipcbind` option to `bitcoin-node`, and an `-ipcconnect` option to
`bitcoin-wallet` to allow running a node that listens on an IPC socket and
accepts connections from wallet processes.
Example usage:
src/bitcoin-node -regtest -debug -ipcbind=unix
src/bitcoin-wallet -regtest -ipcconnect=unix info
`bitcoin-wallet` tool doesn't really do anything with its connection to the
node yet, but it could potentially run or serve RPCs that require being online.
This was referenced May 21, 2023
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
Korosiua1206
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR because it is based on #10102. The non-base commits are:
bbefbd3c199bmultiprocess: Add -ipcconnect and -ipcbind optionsBuilding on #10102, this adds an
-ipcconnectoption tobitcoin-walletand an-ipcbindoption tobitcoin-node(both enabled by default in multiprocess builds) so bitcoin node will listen on a<datadir>/sockets/node.sockunix socket, andbitcoin-walletwill connect to it.The idea is that
bitcoin-walletcan be extended in the future to have some online functionality. For example, there could be abitcoin-wallet synccommand that will update balances and sync latest transactions to an unloaded wallet, or abitcoin-wallet servesubcommand that loads a wallet and serves RPC requests, or abitcoin-wallet shellsubcommand that allows running RPC methods interactively like the GUI console, or just general support forbitcoin-wallet <rpc method> <rpc params>invocations suggested #13926 (comment).This PR is small and doesn't do much. The only visible change is that
bitcoin-walletnow checks whether a node socket exists on startup and prints "Connected to IPC address" if it can connect it it.The default
bitcoin-walletconnect option is-ipcconnect=auto, which connects if possible as described above, and proceeds offline if not possible. Other supported options are-noipcconnectto disable ipc,-ipcconnectto require a connection and fail if it can't be established, and-ipcconnect=unix:<socket>to require a connection and use a custom socket path.These changes require multiprocess support and this PR has no effect unless bitcoin is configured with
--enable-multiprocessas described in doc/multiprocess.mdThis PR is part of the process separation project.