BIP 341: Specify Speedy Trial activation parameters #1081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes (mistakenly I think) the commit making changes to BIP 8. This PR should only be making changes to BIP 341. |
achow101
force-pushed
the
taproot-activation-params
branch
from
57f7ea4
to
0bc3ec5
Compare
It is not mistaken. This PR requires BIP 8 to discuss the minimum activation height. |
|
Concept ACK. Can you add estimated dates next to the heights? I'd like to see bitcoin/bitcoin#21392 merged and backported before committing to specific heights. Ideally I'd also like to see another client implement the speedy trial mechanism.
|
achow101
force-pushed
the
taproot-activation-params
branch
from
0bc3ec5
to
f0ea9c2
Compare
|
Added approximate dates |
flack
reviewed
Mar 20, 2021
achow101
force-pushed
the
taproot-activation-params
branch
2 times, most recently
from
c3f2d26
to
3704017
Compare
|
ACK 3704017 |
ajtowns
reviewed
Mar 24, 2021
achow101
force-pushed
the
taproot-activation-params
branch
from
3704017
to
1572d1b
Compare
|
This misses activating BIP342 -- suggest rebasing on #1091 to fix that. |
achow101
force-pushed
the
taproot-activation-params
branch
from
1572d1b
to
5111f86
Compare
|
Rebased onto #1091 |
Sjors
reviewed
Mar 26, 2021
achow101
force-pushed
the
taproot-activation-params
branch
from
5111f86
to
4c79a18
Compare
|
Should this be closed now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifies activation parameters for BIP 341 using the Speedy Trial activation proposal discussed on the bitcoin-dev mailing list.
Testnet parameters were not discussed so I just chose block heights that corresponded to a start time of 2021/04/18 with 3 retarget periods of activation time and an additional 3 retarget periods for the minimum activation height.
Requires #1080 as it uses the
minimum_activation_heightspecified there.