Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13: Replace deprecated PyEval_CallObject() #4706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

penguinpee
Copy link

The function has been deprecated since Python 3.9 and will be removed
from Python 3.13.

See: https://docs.python.org/3.13/whatsnew/3.13.html#id9

The function has been deprecated since Python 3.9 and will be removed
from Python 3.13.

See: https://docs.python.org/3.13/whatsnew/3.13.html#id9
@peterjc
Copy link
Member

peterjc commented Apr 19, 2024

Do you agree to the licensing terms in the PR template? i.e. to dual-license this and any previous contributions under both the Biopython License Agreement AND the BSD 3-Clause License.

https://github.com/biopython/biopython/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@penguinpee
Copy link
Author

penguinpee commented Apr 19, 2024

I guess that PR template only shows when submitting a PR using the Web UI.

I'm fine with the dual licensing. I don't think it's worth the effort adding myself as a listed contributor.

@peterjc
Copy link
Member

peterjc commented Apr 19, 2024

That's great. Out of interest, how did you open the PR then?

@peterjc peterjc requested a review from mdehoon April 19, 2024 13:20
@penguinpee
Copy link
Author

gh pr create --fill using GitHub's command line tool

@peterjc
Copy link
Member

peterjc commented May 3, 2024

@mdehoon can you comment on the Python + C side please?

@mdehoon
Copy link
Contributor

mdehoon commented May 4, 2024

Probably it's OK, but PyEval_CallObject and PyObject_CallObject are not exactly the same.
Perhaps it is time to remove Bio.pairwise2, as it was deprecated in release 1.80, and the next release will be 1.84.

@peterjc
Copy link
Member

peterjc commented May 4, 2024

Given the steady stream of queries about pairwise2, I'd prefer not to remove it quite yet.

The tests seem fine, so we should be OK with this change...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants