Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check sorting of CONTRIB.rst vis pre-commit #4478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented Oct 31, 2023

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run pre-commit
    locally, and understand that continuous integration checks will be used to
    confirm the Biopython unit tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

We used to run grep "^- " CONTRIB.rst | LC_ALL=C sort -u -c -f as part of the TravisCI setup (as documented at the start of that file), but appear not to be under GitHub Actions or AppVeyor.

Cross reference 99cbeb5

This solution via pre-commit is not that elegant, perhaps there is an easier way - e.g. an entry in the GitHub actions directly?

@peterjc
Copy link
Member Author

peterjc commented Oct 31, 2023

Meant this to be one commit; the first attempt fails.

Bit of a hack as the syntax is for a command
to be run on one or more filenames as args.
@peterjc
Copy link
Member Author

peterjc commented Dec 22, 2023

Rebasing (wanted to double check this still works)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant