MultipleSeqAlignment position mapping #4249
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…q` when it returns a `str`
…apping between alignment indexes and original sequence positions
…fferent seq) position
|
The automated checks are failing due to your Python style, please see https://github.com/biopython/biopython/blob/master/CONTRIBUTING.rst - at least try running the tool black on your Python code. |
peterjc
reviewed
Mar 1, 2023
| @@ -904,13 +1093,13 @@ def substitutions(self): | |||
|
|
|||
| Any weights associated with the sequences are taken into account when | |||
| calculating the substitution matrix. For example, given the following | |||
| multiple sequence alignment:: | |||
| multiple sequence alignment: | |||
There was a problem hiding this comment.
Please revert this change, the double colon is RST markup indicating the following indented code is a literal block. Same for the change below.
|
I wonder if it would be best to more closely match the new alignment object's mapping via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile, have runpre-commitlocally, and understand that continuous integration checks will be used to
confirm the Biopython unit tests and style checks pass with these changes.
I have added my name to the alphabetical contributors listings in the files
NEWS.rstandCONTRIB.rstas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)
Closes #4248