Fix same line implicit string concatenation from black #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an open issue on black for fixing this. Spotted while testing a new flake8 plugin: https://github.com/keisheiled/flake8-implicit-str-concat/
Codecov Report
@@ Coverage Diff @@
## master #2358 +/- ##
=======================================
Coverage 84.95% 84.95%
=======================================
Files 323 323
Lines 52690 52690
=======================================
Hits 44764 44764
Misses 7926 7926
Continue to review full report at Codecov.
|
3 tasks
|
Now covered in #2359 along with using a new flake8 plugin to enforce this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open issue on black for fixing this:
psf/black#26 (comment)
These specific cases were spotted while testing a new flake8 plugin:
https://github.com/keisheiled/flake8-implicit-str-concat/
Once that plugin as matured a little, we should start using it on our continuous integration testing (at least until the black issue is addressed).
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile, have runflake8locally, andunderstand that AppVeyor and TravisCI will be used to confirm the Biopython unit
tests and style checks pass with these changes.
I have added my name to the alphabetical contributors listings in the files
NEWS.rstandCONTRIB.rstas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)