Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(biome_css_analyze): noDuplicateSelectors #2660

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

feat(biome_css_analyze): noDuplicateSelectors #2660

wants to merge 22 commits into from
+1,251 −51

Commits on Apr 25, 2024

  1. Bootstrapped and added basic logic and failing tests.

    @abidjappie
    abidjappie committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    564b995 View commit details
    Browse the repository at this point in the history

  2. Added some helpful comments and save progress.

    @abidjappie
    abidjappie committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    08c949e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. WIP: it currently returns everything in a single run, we need to spli… 

    …t it into multiple runs.
    @abidjappie
    abidjappie committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c4674af View commit details
    Browse the repository at this point in the history

  2. Working solution excluding some edge cases, still using a visitor nee… 

    …ds to be simplified.
    @abidjappie
    abidjappie committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    99af5a2 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. WIP: removed the visitor, simplified the logic, added stylelint test … 

    …cases. TODO: finish updating the logic - some issues with resolving.
    @abidjappie
    abidjappie committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b6b3d1e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. WIP: Added option cases, many more test cases are passing. Next: pass… 

    … all test cases.
    @abidjappie
    abidjappie committed May 3, 2024
    Configuration menu
    Copy the full SHA
    87a6f5e View commit details
    Browse the repository at this point in the history

  2. WIP: Fixed test case. some cleaning.

    @abidjappie
    abidjappie committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3965886 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. All the current valid and invalid cases are now working as expected. … 

    …TODO: add tests for Options.
    @abidjappie
    abidjappie committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3d58e8e View commit details
    Browse the repository at this point in the history

  2. Added option test cases, updated the diagnostics. WIP: cleanup.

    @abidjappie
    abidjappie committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3ed2b90 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Ran gen-lint.

    @abidjappie
    abidjappie committed May 6, 2024
    Configuration menu
    Copy the full SHA
    65e6ba9 View commit details
    Browse the repository at this point in the history

  2. Added more test cases, adjusted the at-rule logic.

    @abidjappie
    abidjappie committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0b51c52 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Code structure improvements and simplifications.

    @abidjappie
    abidjappie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    40de23d View commit details
    Browse the repository at this point in the history

  2. Linting.

    @abidjappie
    abidjappie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2ed1405 View commit details
    Browse the repository at this point in the history

  3. Added additional test cases, updated the diagnostic messages.

    @abidjappie
    abidjappie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8feeeda View commit details
    Browse the repository at this point in the history

  4. Fixed typo.

    @abidjappie
    abidjappie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    648ffdd View commit details
    Browse the repository at this point in the history

  5. Fixed merge conflicts, gen.

    @abidjappie
    abidjappie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6ed13f2 View commit details
    Browse the repository at this point in the history

  6. Better diagnostic reporting.

    @abidjappie
    abidjappie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e667f3c View commit details
    Browse the repository at this point in the history

  7. Addressed linter feedback. WIP: addressing review feedback.

    @abidjappie
    abidjappie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7e2b209 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. WIP: added comments.

    @abidjappie
    abidjappie committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4471c4f View commit details
    Browse the repository at this point in the history

  2. WIP: added comments.

    @abidjappie
    abidjappie committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f453e8c View commit details
    Browse the repository at this point in the history

  3. Handle the text in the diagnostics.

    @abidjappie
    abidjappie committed May 8, 2024
    Configuration menu
    Copy the full SHA
    911eacf View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Fixed merge conflicts, gen.

    @abidjappie
    abidjappie committed May 9, 2024
    Configuration menu
    Copy the full SHA
    04556f6 View commit details
    Browse the repository at this point in the history