Remove ruamel.yaml dependency #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
fixes #209 |
constantinpape
approved these changes
Aug 2, 2021
|
@FynnBe Great! Could you make a new release so we can try it with pyodide? |
|
sure, let's wait for #214 to be merged and then go ahead with a little new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruamel.yaml is not supported by Pyodide, therefor we use PyYAML instead.
problem: PyYAML currently only supports yaml 1.1, whereas ruamel.yaml (what we used until now) defaults to yaml 1.2.
Differences: https://yaml.readthedocs.io/en/latest/pyyaml.html#defaulting-to-yaml-1-2-support
The one difference that might be most relevant for us: "correct parsing of floating point scalars with exponentials" is added manually to the current ruamel.yaml replacement.
see yaml/pyyaml#173 and https://stackoverflow.com/questions/30458977/yaml-loads-5e-6-as-string-and-not-a-number.
Also note that not all valid json is compatible with yaml 1.1 (but with yaml 1.2).
With this yaml 1.1/1.2 hybrid we should be good for now and can hopefully switch easily to the full yaml 1.2 in the future.