Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice to README #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bmish
Copy link

@bmish bmish commented Jan 18, 2022

Using the ember-cli linting plugins has been deprecated for years based on the RFC linked to below. ember-cli-eslint and ember-cli-template-lint have already been marked deprecated and have deprecation notices in their READMEs as linked to below.

In this PR, I'm proposing/implementing a deprecation notice suggesting to use stylelint directly instead. If this is accepted, the maintainer should also run the following command to mark the package as deprecated in the NPM registry:

npm deprecate ember-cli-stylelint "Use stylelint directly instead: https://github.com/emberjs/rfcs/blob/master/text/0121-remove-ember-cli-eslint.md"

By using stylelint directly, we mean that Ember apps should tell their CI to run their lint script the same way it runs their test script. The lint scripts in package.json usually look roughly like this in Ember apps (simplified version from ember-cli blueprint):

"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
"lint:css": "stylelint .",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint .",

More info:

@bmish
Copy link
Author

bmish commented Dec 2, 2022

@billybonks mind if we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant