Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Laravel 9 #421

Merged
merged 11 commits into from
Feb 21, 2022
Merged

Upgrade to Laravel 9 #421

merged 11 commits into from
Feb 21, 2022

Conversation

mzur
Copy link
Member

@mzur mzur commented Feb 14, 2022

Laravel 9 was just released as new LTS version. We should upgrade until Laravel 6.x support is dropped on September 6th, 2022. Also check which new features we could use to simplify code:

  • Do the upgrade from 6.x to 7.x
  • Do the upgrade from 7.x to 8.x
  • Do the upgrade from 8.x to 9.x
  • Upgrade the Swift adapter to Flysystem 3.x
  • Maybe use job batching (e.g. for laser point detection, processing of new images/videos)
  • Maybe use the new http client instead of Guzzle directly, which could simplify tests
    • Guzzle isn't used too often. There is too little benefit of changes.
  • Maybe use the new artisan test command
    • Too verbose.
  • Check out and maybe customize the new markdown mail template
    • No need, they are fine.
  • Move model classes to app/Models
  • Implement model factory classes
  • Use migration squashing
    • Maybe not as it could clash with module migrations?
  • Use the new rate limiter
  • Make sure the rendered paginations are still Bootstrap 3
  • Use the new routing namespace definition
    • Too many use statements in the route file for my taste. We'll keep the namespace and string definitions.
  • Maybe use enum casting for "static models" (e.g. role, shape)
    • Requires PHP 8.1 and offers little benefit to the existing implementation.
  • Use checked/selected Blade directives
  • Find a way to enable Psalm linting with the Laravel plugin again (it seems to support only Laravel 6.x and 8.x)
  • Enable API rate limiting by adding the api middleware group to the API routes in the RouteServiceProvider
    • Rate limiting was disabled before so do this carefully. Make an announcement once this is implemented.
  • Merge pull requests of modules
  • Add migration instructions to release notes

@mzur mzur added the 2024 To be finished in 2024 label Feb 14, 2022
This was referenced Feb 14, 2022
@mzur mzur mentioned this pull request Feb 21, 2022
@mzur mzur marked this pull request as ready for review February 21, 2022 15:37
@mzur mzur merged commit 6a9bbc6 into master Feb 21, 2022
@mzur mzur deleted the laravel-9 branch February 21, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024 To be finished in 2024
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant