Parse data from NY's historical PDFs #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Responding to the call-out here: biglocalnews#476 This being my first commit to the project, and not knowing how the maintainers would like to handle the overlap between the data sources, I tried to take the least destructive approach.
palewire
requested changes
May 25, 2022
|
Added a commit addressing your (very reasonable) requests 👍 |
|
Great. Thank you. Do we have any overlap and duplication between the PDFs and our other data sources? |
|
Looks like there's quite a bit of overlap, both in actual data and timeframes. I don't know enough, however, about the history/provenance of the non-PDF data files to suggest which source(s) should take precedence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to the call-out here: #476
This being my first commit to the project, and not knowing how the maintainers would like to handle the overlap between the data sources, I tried to take the least destructive approach.
And I think I obeyed the Contribution guidelines, but don't hesitate to holler if I haven't.
Also, in order to get the pre-commit hook to pass, I had to upgrade two dependencies in
.pre-commit-config.yaml, due to changes inpsf/black. (Cf.: psf/black#2966 and adamchainz/blacken-docs#141.) Let me know if there's another way you'd like that handled.